fix: insight filters and UI not in sync #17868
Conversation
There was a problem hiding this comment.
The code looks good, but this grouping of options is quite dubious:
The time range etc. settings look as if they belonged to "Sampling". Their layout and that of the existing query definition settings are from different worlds.
In these PostHog 3000 mocks from Cory, he proposed putting the options inside the "widget", just at the bottom to take away the clutter from the top.
That's one way to do it. The other is that we can put them in the side panel, ideally at the top or sticky at the bottom – but with the same layout (headings and all) as all the other settings.
|
@Twixes I think this should be the "lets get it working" solution for now and we tackle the proper solution in a way that works everywhere. Otherwise we will get stuck |
|
Yeah yeah @benjackwhite that's a comment but not a blocker. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
Still working on this but just blocked by the Product Analytics work to fix queries (coming next week) |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Problem
Right now the filters shown in the header of an insight are not editable in a notebook. This means that there is no way to update the time range of a query.
Changes
Note: Sacrificing the title above the display filters because that would mean adding an entirely separate
Querycomponent which I'm not sure is worth the extra complexity until we're certain this is how insight editing will look going forwardThere is a bug with this implementation that means the query is never updated. There is an internal hook in
setQuerythat is not being called somewhereMismatch.video.mp4
How did you test this code?
Visually